don't do diagnostics when workspace is not ready #2692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+one:) |
Collaborator
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I created a new Neovim plugin that automatically updates the
workspace/libraryconfiguration for the active workspace folder based on what files the user has open in Neovim.It works great and is a lot faster than my older
neodev.nvimplugin.However, one thing I noticed, is that when I send a
workspace/didChangeConfiguration, the diagnostics of the currently open files, become all wrong (things like,string, ortabledoes not exist).After a couple of seconds, they are then replaced by the correct diagnostics.
After debugging, it seems that diagnostics sometimes run, even when the workspace is not ready.
This PR fixes that.